feat: Add selectable currency (AUD/USD/EUR/etc) with dropdown#19
Closed
Azzbo77 wants to merge 1 commit intocachebag:masterfrom
Closed
feat: Add selectable currency (AUD/USD/EUR/etc) with dropdown#19Azzbo77 wants to merge 1 commit intocachebag:masterfrom
Azzbo77 wants to merge 1 commit intocachebag:masterfrom
Conversation
cachebag
requested changes
Jan 18, 2026
Owner
cachebag
left a comment
cachebag
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I'm gonna leave this open for now but I do want to say we already have two other PRs open for this same exact feature.
I think maybe if there are things missing from those PRs that this could come in assist with, I can ping you and maybe we can re-arrange as needed.
Contributor
Author
|
No worries, I did notice the others, but thought I'd add anyway. Thanks for the code :-) |
Owner
|
Closing in favor #18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All existing users default to USD
Currency selection is available immediately in Settings without any special permissions
The feature is backward compatible and doesn't affect existing functionality